Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(create-vite): extend from @vue/tsconfig to simplify tsconfig.app.json #18862

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(create-vite): extend from @vue/tsconfig to simplify tsconfig.app.json #18862

wants to merge 2 commits into from
+2 −13

Conversation

haoqunjiang
Copy link
Member

Description

  • It aligns with the templates created from create-vue.
  • It makes the tsconfig.app.json more concise.
  • @vue/tsconfig has detailed documentation for each of the configuration fields and why they are needed for Vue.js development: https://github.com/vuejs/tsconfig/blob/main/tsconfig.json
  • I think it's easier to manage the TSConfig for Vue.js in a centralized way.
    For example, Vue.js 3.3 added jsxImportSource support, but not many people know this; the default Vite template doesn't have it configured either. But if the user extends from @vue/tsconfig, they will automatically benefit from this new feature when upgrading dependencies.

@ArnaudBarre
Copy link
Member

lib options seems undefined in the extended config and should be kept I think

@haoqunjiang
Copy link
Member Author

It's not empty, as this PR extends from tsconfig.dom.json instead of the base tsconfig.json.

@sapphi-red sapphi-red added the feat: create-vite create-vite package label Dec 3, 2024
sapphi-red
sapphi-red approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can do this. Svelte template uses @tsconfig/svelte.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
feat: create-vite create-vite package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haoqunjiang @ArnaudBarre @bluwy @sapphi-red